Skip to content
This repository was archived by the owner on Sep 19, 2019. It is now read-only.

Conversation

@bdionne
Copy link
Contributor

@bdionne bdionne commented Oct 20, 2011

BugzID:11171

@kocolosk
Copy link
Contributor

I dislike the name shard_info, as it could be interpreted as "information about this shard" when in fact it's information about the sharding topology of the entire database. But more importantly, the patch as written breaks replication compatibility with a number of versions of CouchDB. Can you remind me of which ones? To be safe I'd recommend adding n and q to the other sub-object until we explicitly drop compatibility with the older versions of CouchDB.

@bdionne
Copy link
Contributor Author

bdionne commented Oct 20, 2011

hmm, I thought the compatibility issue related to the handling of atoms and was fixed in couchdb. Anyway it's easy enough and safer to put it into other.

I also agree the name is bogus, both here and in mem3.

@kocolosk
Copy link
Contributor

It is fixed, but we can't retroactively fix versions of CouchDB that are already released ;)

to db_topology and move inside the  tuple in order to maintain
compatibility with earlier versions of couchdb.

BugzID:11171
@wohali
Copy link

wohali commented Dec 4, 2012

This would save some headaches in support and help forgetful people. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants