This repository was archived by the owner on Sep 19, 2019. It is now read-only.
Indicate when read quorums are met #146
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is no indication if a read operation has met the requested quorum level. This patch and a corresponding patch to dbcore enable this indication by adding a special document member _r_met that is set to false when quorum is not met. When the requested quorum is met the field does not exist. This is to ensure no changes for normal use cases. Unfotunately this change breaks replication to any node or cluster that doesn't have these patches. I don't really expect this to be merged as is but the tests were so pretty I couldn't help but finish it off. BugzId: 26369
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no indication if a read operation has met the
requested quorum level. This patch and a corresponding patch to dbcore
enable this indication by adding a special document member
_r_metthatis set to false when quorum is not met. When the requested quorum is met
the field does not exist. This is to ensure no changes for normal use
cases.
Unfortunately this change breaks replication to any node or cluster that
doesn't have these patches. I don't really expect this to be merged as
is but the tests were so pretty I couldn't help but finish it off.
BugzId: 26369