Skip to content

fix: avoid deleting new Application (and subresources) #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathieulaude merged 1 commit into from
Jan 26, 2026
Merged

fix: avoid deleting new Application (and subresources) #1859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions plugins/argocd/src/functions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,29 +146,6 @@ export const upsertProject: StepCall<Project> = async (payload) => {

await removeInfraEnvValues(project, gitlabApi)

// then destroy what should not exist
Copy link
Collaborator

@StephaneTrebel StephaneTrebel Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

// @ts-ignore
for (const application of applications) {
const appEnv = application.metadata.labels['dso/environment']
const appRepo = application.metadata.labels['dso/repository']
const env = project.environments.find(env => env.name === appEnv)
const repo = infraRepositories.find(repo => repo.internalRepoName === appRepo)
if (!env || !repo) {
console.log(`Application ${application.metadata.name} should not exists anymore`)
await customK8sApi.deleteNamespacedCustomObject('argoproj.io', 'v1alpha1', getConfig().namespace, 'applications', application.metadata.name)
}
}

// @ts-ignore
for (const appProject of appProjects) {
const projectEnv = appProject.metadata.labels['dso/environment']
const env = project.environments.find(env => env.name === projectEnv)
if (!env) {
console.log(`AppProject ${appProject.metadata.name} should not exists anymore`)
await customK8sApi.deleteNamespacedCustomObject('argoproj.io', 'v1alpha1', getConfig().namespace, 'appprojects', appProject.metadata.name)
}
}

return {
status: {
result: 'OK',
Expand Down
Loading