Playwright/integration tests #1854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Falltrades
force-pushed
the
playwright/integration-tests
branch
2 times, most recently
from
f142e68 to
4b2fa72
Compare
Falltrades
requested review from
StephaneTrebel,
iliesmrf,
mathieulaude and
shikanime
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
iliesmrf
reviewed
Jan 26, 2026
StephaneTrebel
approved these changes
Jan 26, 2026
| } catch (_) { | ||
| // Element not in DOM yet, ignore | ||
| } | ||
| await page.waitForTimeout(5000) |
Collaborator
There was a problem hiding this comment.
nitpick: y aurait 2/3 contrôles à faire entre ce 5000 (qui devrait être une constante, en passant ^^) et le timeout en entrée, mais bon vu le cas d'usage c'est pas bloquant en soi
| await expect | ||
| .poll( | ||
| async () => { | ||
| await page2.reload({ waitUntil: 'domcontentloaded' }) |
Collaborator
There was a problem hiding this comment.
nitpick: page1, page2, etc. ça a du sens là maintenant mais je suis pas sûr que ce sera le cas demain. N'hésite pas à leur donner des noms signifiants 😉
Falltrades
force-pushed
the
playwright/integration-tests
branch
from
4b2fa72 to
17d30b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues liées
Issues numéro:
Quel est le comportement actuel ?
Quel est le nouveau comportement ?
Cette PR introduit-elle un breaking change ?
No.
Autres informations
Cleanup will fail until #1853 is fixed.