Tiny clarification on environment variables in README.md#25
Open
neilmb wants to merge 1 commit intocloud-gov:mainfrom
Open
Tiny clarification on environment variables in README.md#25neilmb wants to merge 1 commit intocloud-gov:mainfrom
neilmb wants to merge 1 commit intocloud-gov:mainfrom
Conversation
mogul
approved these changes
Nov 21, 2023
markdboyd
reviewed
Jul 23, 2024
| - `cf_manifest:` to use a different manifest file (instead of the default `manifest.yml`) | ||
| - `cf_vars_file:` to [specify values for variables in the manifest file](https://docs.cloudfoundry.org/devguide/deploy-apps/manifest-attributes.html#variable-substitution) | ||
| - `cf_command:` to specify a CF sub-command to run (instead of the default `push -f $MANIFEST -vars-file $VARS_FILE --strategy rolling`) | ||
| - `cf_command:` to specify a CF sub-command to run (instead of the default `push -f $cf_manifest -vars-file $cf_vars_file --strategy rolling`) |
Contributor
There was a problem hiding this comment.
Suggested change
| - `cf_command:` to specify a CF sub-command to run (instead of the default `push -f $cf_manifest -vars-file $cf_vars_file --strategy rolling`) | |
| - `cf_command:` to specify a CF sub-command to run (instead of the default `push -f $MANIFEST --strategy rolling`) |
So the default command does not include a vars file: https://github.com/cloud-gov/cg-cli-tools/blob/main/entrypoint.sh#L38
And $MANIFEST is the variable that is used, which will respect the value of cf_manifest if set, otherwise it will default to manifest.yml:
https://github.com/cloud-gov/cg-cli-tools/blob/main/entrypoint.sh#L30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
cf_manifestand thecf_vars_filevariables