fix: unresolved JSON strings aren't valid JSON #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we have a JSON string (like container definitions) if it is unresolved we are inserting a reference string in there to what was unresolved but its not valid JSON so if anyone uses `fromjson()` on it it will fail. This detects JSON strings and formats it properly while maintaining the reference.
ajkerrigan
approved these changes
Dec 9, 2025
Member
ajkerrigan
left a comment
ajkerrigan
left a comment
There was a problem hiding this comment.
Thanks @sontek , good catch!
At first glance I wondered if given the use case it would be clearer as a c7n-left-specific tweak to the custom jmespath function, but it seems like a better call to catch this at parse time and make the downstream piece simpler 👍 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have a JSON string (like container definitions) if it is unresolved we are inserting a reference string in there to what was unresolved but its not valid JSON so if anyone uses
fromjson()on it it will fail.This detects JSON strings and formats it properly while maintaining the reference.