David Peñasco, Ibai Moya, Nicolas Pérez#11
Open
David52PG wants to merge 20 commits intoclopezno:masterfrom
Open
David Peñasco, Ibai Moya, Nicolas Pérez#11David52PG wants to merge 20 commits intoclopezno:masterfrom
David52PG wants to merge 20 commits intoclopezno:masterfrom
Conversation
Extract method 'private double amountFor(Rental aRental)' from 'ubu.gii.dass.refactoring.Customer.statement()' to 'ubu.gii.dass.refactoring.Customer' - Original project: 'refactoring-fowler-example' - Method name: 'amountFor' - Destination type: 'ubu.gii.dass.refactoring.Customer' - Declared visibility: 'private'
Revertido commit anterior debido a un error al referirse al issue correspondiente.
Extract method 'private double amountFor(Rental aRental)' from 'ubu.gii.dass.refactoring.Customer.statement()' to 'ubu.gii.dass.refactoring.Customer' - Original project: 'refactoring-fowler-example' - Method name: 'amountFor' - Destination type: 'ubu.gii.dass.refactoring.Customer' - Declared visibility: 'private'
…enterPoints() Extract method 'private int incrementFrequentRenterPoints(int frequentRenterPoints, Rental each)' from 'ubu.gii.dass.refactoring.Customer.statement()' to 'ubu.gii.dass.refactoring.Customer' - Original project: 'refactor_buena' - Method name: 'incrementFrequentRenterPoints' - Destination type: 'ubu.gii.dass.refactoring.Customer' - Declared visibility: 'private'
Move method 'ubu.gii.dass.refactoring.Customer.amountFor(...)' to 'ubu.gii.dass.refactoring.Customer.amountFor(...).aRental' - Original project: 'refactoring-fowler-example' - Original element: 'ubu.gii.dass.refactoring.Customer.amountFor(...)' - Moved method: N/A - Target element: 'ubu.gii.dass.refactoring.Customer.amountFor(...).aRental' - Method name: 'amountFor'
…RenterPoints, Rental each)' to 'updatePoints(int frequentRenterPoints, Rental each)' Change method 'private int ubu.gii.dass.refactoring.Customer.incrementFrequentRenterPoints(int frequentRenterPoints, Rental each)' to 'private int updatePoints(int frequentRenterPoints, Rental each)' - Original project: 'refactoring-fowler-example' - Original element: 'ubu.gii.dass.refactoring.Customer.incrementFrequentRenterPoints(...)' - New name: 'updatePoints'
Change method 'double ubu.gii.dass.refactoring.Rental.amountFor()' to 'public double getCharge()' - Original project: 'refactoring-fowler-example' - Original element: 'ubu.gii.dass.refactoring.Rental.amountFor()' - New name: 'getCharge' - New visibility: 'public'
cada clase que herede precio sera un tipo de precio de peliculas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.