Remove fixed width/height of 500px from decision graph svg#276
Remove fixed width/height of 500px from decision graph svg#276chbrown wants to merge 1 commit intoclojure-liberator:gh-pagesfrom
Conversation
This makes it default to full size when viewed alone, but does not change the appearance of the embedding in the tutorial.
|
Hey Christopher, thank you for the contribution. Did you check if the updated graph also works correctly in the debug trace view? |
|
I hadn't come across the debug trace view; the first time I tried So I added compojure to my dev dependencies and hey, wrap-trace is really handy! And it appears that the debug trace uses an entirely different svg, specifically, https://github.com/clojure-liberator/liberator/blob/master/src/liberator/trace.svg |
|
Yes, sorry it does. Although they should be in sync preferrably. |
|
It would be great to have this resolved. @chbrown , any chance you can push this to completion? |
|
Thanks for your reminder, @cch1; the change I made works just fine (i.e., the updated graph does also work correctly in the debug trace view). Presumably, the blocker — de-duplicating the different svg sources — is more of a build artifact, which depends on how @ordnungswidrig keeps the docs/gh-pages and master in sync. |
The tutorial's decision graph page, https://clojure-liberator.github.io/liberator/tutorial/decision-graph.html, links to the raw SVG image at https://clojure-liberator.github.io/liberator/assets/img/decision-graph.svg, but due to the
<svg>element's fixed dimensions, is very small, and no easier to navigate than the embedded version.Since the container (a
<span>withdisplay: block!) has fixed dimensions, this does not overflow in the constrained space of the tutorial, as you can see at https://chbrown.github.io/liberator/tutorial/decision-graph (thispatch-1branch is already merged into thegh-pagesbranch in my fork)Compare https://chbrown.github.io/liberator/assets/img/decision-graph.svg, which, in my opinion, is easier to explore.