Skip to content

Conversation

@Boegie19
Copy link
Contributor

@Boegie19 Boegie19 commented Jan 16, 2026

Description of Changes

in the llm tests we run to see if docs update break llms.
we are making sql queries to tables that we did not set to public what means the sql query will fail

API and ABI breaking changes

Expected complexity level and risk

1

Testing

Run /update-llm-benchmark and see if it fixes the sql query issues.

@cloutiertyler
Copy link
Contributor

@Boegie19 I don't think we should update the answers to expect public be explicit. Public is (or should be) the default. If it is not we should fix that instead.

@egormanga
Copy link
Contributor

Public is (or should be) the default

It isn't, and changing this would be a major security breaking change for existing codebases, which I'm sure should not happen unless bumping to 2.0 and providing a source migration tool.

@cloutiertyler
Copy link
Contributor

Sorry! I am a fool! They are private by default, not public.

@Boegie19
Copy link
Contributor Author

Boegie19 commented Jan 16, 2026

@cloutiertyler Can you run /update-llm-benchmark ? if it works.

Signed-off-by: Boegie19 <34578426+Boegie19@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants