Add garbage collection on buckets #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clipperhouse
force-pushed
the
clipperhouse/gc
branch
4 times, most recently
from
e39fe19 to
6d292c3
Compare
clipperhouse
force-pushed
the
clipperhouse/gc
branch
from
6d292c3 to
0d9bb66
Compare
Owner
Author
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no bugs!
Bugbot free trial expires on August 27, 2025
Learn more in the Cursor dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bucketMapwill currently grow unbounded. This PR implements a GC to remove no-longer-valuable buckets.A bucket is no longer valuable when it is full due to the passage of time. A non-existent bucket is semantically equivalent to a full bucket; we create buckets full.
isFullmethod tobucket, which tests that its time is before or equal to now - limit.period.gcmethod onbucketMap. Loop through all keys (buckets), delete ifisFullLimiter[s].GCandClearA design decision here is not to run GC on the user’s behalf. We offer the primitive, and the user can choose timing.