Check that equivalent units did change the answer.#4
Merged
climbfuji merged 1 commit intoclimbfuji:feature/equivalent_unitsfrom Apr 19, 2025
Conversation
climbfuji
reviewed
Apr 19, 2025
Owner
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Thanks for this. I think we need to go one step further (I can do that next week) and modify the/a value in the scheme (e.g. times 2) and then test after running the physics for the expected value.
climbfuji
merged commit 6e4576a
into
climbfuji:feature/equivalent_units
5 checks passed
climbfuji
added a commit
that referenced
this pull request
Jul 24, 2025
…an modules in the correct place (#4) Update CMakeLists.txt to: - Bring in updates from NCAR ccpp-framework main as needed and update CMakeLists.txt to modern cmake version 3 - Support NEPTUNE cmake build while retaining compatibility with UFS/SCM
climbfuji
added a commit
that referenced
this pull request
Oct 23, 2025
…an modules in the correct place (#4) Update CMakeLists.txt to: - Bring in updates from NCAR ccpp-framework main as needed and update CMakeLists.txt to modern cmake version 3 - Support NEPTUNE cmake build while retaining compatibility with UFS/SCM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will test that the equivalent unit doesn't change the answers.
@peverwhee requested this in NCAR#571