ci: metrics: disable ksm on global proxy if under metrics #911
Conversation
If running under the metrics CI, then we want to disable the global KSM control of the proxy, and control it ourselves. This is effectively an unwind of clearcontainers#828, that was a touch premature. Fixes: clearcontainers#910 Signed-off-by: Graham Whaley <graham.whaley@intel.com>
|
Please scrutinize - I've not gotten to run test this locally (but maybe we'll see what the metrics CI makes of it...) |
|
kubernetes qa-passed 👍 |
|
lgtm lets compare new metrics to know if got expected values. |
|
The CI is looking good to me - I now only see one entry for |
|
Marking as DNM whilst I open an Issue to discuss the 'real' issue... |
| systemd_extra_flags="${systemd_extra_flags} -ksm initial" | ||
| fi | ||
|
|
||
| proxy_systemd_file=$(sudo systemctl show cc-proxy | fgrep FragmentPath | awk 'BEGIN{FS="="}{print $2}') |
There was a problem hiding this comment.
wait, the proxy is no more a systemd service.
also awk is not needed, sudo systemctl -p FragmentPath show cc-proxy | cut -d= -f2 works
There was a problem hiding this comment.
but, that is the problem - the proxy still is a systemd service under the CIs:
https://github.com/clearcontainers/tests/blob/master/.ci/install_proxy.sh
https://github.com/clearcontainers/proxy/blob/master/Makefile#L88
we have a mis-match between the packaging distro installs and the CI scripted installs - we opened a few new Issues on Thursday about this. Need input from @chavafg I think. Let me see if I can find those other relevant issues...
There was a problem hiding this comment.
We are not installing cc-proxy service files any more. This was removed some time ago: dd24a5b
There was a problem hiding this comment.
Sorry, I see that the make install rule of the proxy still installs the service files, but I think we do not make use of them. clearcontainers/proxy#177 should solve this, right?
There was a problem hiding this comment.
but clearcontainers/proxy#177 is not merged ;-)
So, today we do install and run the proxy on the CI systems afaict - and that messes up my metrics CI memory measurements ;-)
Either we
- turn it off again with this patch (quick fix)
- or we fix the .ci install scrips and proxy Makefile and replace it with ksm-throttler installation (the better fix, but will take a little more work to write the scripts)
There was a problem hiding this comment.
We're going to need to resolve #913 (create .ci/install_ksm_throttler.sh) first because if I get clearcontainers/proxy#177 landed, the CI and PnP will immediately break fwics as there will be no KSM functionality in the proxy.
There was a problem hiding this comment.
ohh ok, then, to me it is ok to merge this and have a proper fix once clearcontainers/proxy#177 gets merged.
There was a problem hiding this comment.
metrics CI will be very happy if there is no KSM via either proxy or ksm-throtter ;-) - metrics CI controls KSM itself so it knows exactly what it is measuring...
but, yes, QA CI should have ksm-throttler running so we are testing the 'same' environment you'd get if you installed from the distro packages.
jodh-intel
left a comment
jodh-intel
left a comment
There was a problem hiding this comment.
As a temporary fix until #913 lands...
lgtm
|
thx - have dropped the DNM - anybody fancy hitting the big green button... |
|
💥 💥 💥 |
If CI envar is not found, the setup.sh script fails because of an unbound variable. Add default value of CI=false Fixes clearcontainers#911. Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
6 participants
If running under the metrics CI, then we want to disable the global
KSM control of the proxy, and control it ourselves.
This is effectively an unwind of #828, that was a touch premature.
Fixes: #910
Signed-off-by: Graham Whaley graham.whaley@intel.com