Skip to content
This repository was archived by the owner on May 6, 2020. It is now read-only.

Conversation

@jodh-intel
Copy link

Previously, the identifier used for each proxy log message specified
the full path to the proxy binary. This meant that to select proxy log
messages it was necessary to specify:

$ sudo journalctl -t /usr/libexec/clear-containers/cc-proxy

Now, the user can perform the same action with a simple:

$ sudo journalctl -t cc-proxy

Fixes #180.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

Previously, the identifier used for each proxy log message specified
the full path to the proxy binary. This meant that to select proxy log
messages it was necessary to specify:

```
$ sudo journalctl -t /usr/libexec/clear-containers/cc-proxy
```

Now, the user can perform the same action with a simple:

```
$ sudo journalctl -t cc-proxy
```

Fixes clearcontainers#180.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@clearcontainersbot
Copy link

kubernetes qa-passed 👍

Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch
lgtm

@grahamwhaley
Copy link
Contributor

just a thought - are there any scripts or tools that do log scraping and collating we need to update to match this ?

@grahamwhaley grahamwhaley merged commit f2a57e8 into clearcontainers:master Dec 6, 2017
@jodh-intel
Copy link
Author

Good question. The still-unfinished clearcontainers/tests#590 circumvents the issue by requiring the user to pass the required journal extracts.

@sboeuf, @chavafg - can you check for anything else that might be impacted by this?

@chavafg
Copy link
Contributor

chavafg commented Dec 6, 2017

@jodh-intel, @grahamwhaley we use sudo journalctl -u cc-proxy in the teardown.sh script, so we are fine. :)

@jodh-intel
Copy link
Author

@chavafg - actually, "yes and no" - that now needs to be sudo journalctl -t cc-proxy due to clearcontainers/runtime#835. We still launch the system-level cc-proxy instance, but it's inert and we'll be removing that soon when #177 lands.

@chavafg
Copy link
Contributor

chavafg commented Dec 6, 2017

ohh, that's true, forgot about that change, then I'll open a PR to update it.

@jodh-intel
Copy link
Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants