Conversation
mumbler6
force-pushed
the
733-inote-editor-dont-use-index-position-for-keys-for-items-in-a-react-list
branch
from
eaf7524 to
12b60bf
Compare
Contributor
Author
|
Force pushed to remove test case files that will be going in a separate draft PR. |
harsh183
reviewed
Jun 11, 2024
| /> | ||
| ))} | ||
| {contents.map((content, index) => { | ||
| const uuid = uuidv4(); |
Member
There was a problem hiding this comment.
Small readability improvement if you change the key to ch-content-${id}-${uuidv4()} instead of having a variable you don't need the extra set of brackets and return keyword for these components. Since we only call the function once, I think not having a variable is fine in this case.
harsh183
reviewed
Jun 11, 2024
| @@ -1,5 +1,6 @@ | |||
| import React from 'react'; | |||
| import { CTFragment } from 'layout'; | |||
| import { v4 as uuidv4 } from 'uuid'; | |||
Member
There was a problem hiding this comment.
uuidv4 is totally a better name, nice pick!
harsh183
reviewed
Jun 11, 2024
|
|
||
| return ( | ||
| <Box style={boxstyle}> | ||
| <Box style={boxstyle} data-testid="tag"> |
Member
There was a problem hiding this comment.
maybe we can rename the test id to include the component name like "ChapterContent-test-tag" in the case we ever have a test with lots of different components?
Member
|
Great PR! I've left some comments here and #823 |
angrave
deleted the
733-inote-editor-dont-use-index-position-for-keys-for-items-in-a-react-list
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #733