Skip to content

chore(core): bump nostr-lock mainnet cell deps #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hanssen0 merged 1 commit into from
Jan 15, 2026
Merged

chore(core): bump nostr-lock mainnet cell deps #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/shaggy-gifts-drum.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@ckb-ccc/core": patch
---

chore(core): bump nostr-lock mainnet cell deps

2 changes: 1 addition & 1 deletion packages/core/src/client/clientPublicMainnet.advanced.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ export const MAINNET_SCRIPTS: Record<KnownScript, ScriptInfoLike | undefined> =
cellDep: {
outPoint: {
txHash:
"0x1911208b136957d5f7c1708a8835edfe8ae1d02700d5cb2c3a6aacf4d5906306",
"0x99b116dd1e4f1fa903b70112ae672c18bb34241d3d03a9ad555cd2a611be7327",
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better long-term maintainability, it's helpful to add a comment explaining the origin of this transaction hash. The pull request description provides valuable context about the new deployment, and capturing this information in the code will help developers in the future understand where this value comes from without needing to search through git history.

Suggested change
"0x99b116dd1e4f1fa903b70112ae672c18bb34241d3d03a9ad555cd2a611be7327",
"0x99b116dd1e4f1fa903b70112ae672c18bb34241d3d03a9ad555cd2a611be7327", // From nostr-binding@eef134e

index: 0,
},
depType: "code",
Expand Down