-
Notifications
You must be signed in to change notification settings - Fork 34
feat(btc): add PSBT signing and broadcasting support #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
e9a3a6e
19490f4
b4d9e5e
efcdcd8
7b16831
8f4091f
f3e3c7f
6c31f8c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| export * from "./psbt.js"; | ||
| export * from "./signerBtc.js"; | ||
| export * from "./signerBtcPublicKeyReadonly.js"; | ||
| export * from "./verify.js"; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /** | ||
| * Options for signing a PSBT (Partially Signed Bitcoin Transaction) | ||
| */ | ||
| export type SignPsbtOptions = { | ||
| /** | ||
| * Whether to finalize the PSBT after signing. | ||
| * Default is true. | ||
| */ | ||
| autoFinalized?: boolean; | ||
| /** | ||
| * Array of inputs to sign | ||
| */ | ||
| toSignInputs?: ToSignInput[]; | ||
| }; | ||
|
|
||
| /** | ||
| * Specification for an input to sign in a PSBT. | ||
| * Must specify at least one of: address or pubkey. | ||
| */ | ||
| export type ToSignInput = { | ||
| /** | ||
| * Which input to sign (index in the PSBT inputs array) | ||
| */ | ||
| index: number; | ||
| /** | ||
| * (Optional) Sighash types to use for signing. | ||
| */ | ||
| sighashTypes?: number[]; | ||
| /** | ||
| * (Optional) When signing and unlocking Taproot addresses, the tweakSigner is used by default | ||
| * for signature generation. Setting this to true allows for signing with the original private key. | ||
| * Default value is false. | ||
| */ | ||
| disableTweakSigner?: boolean; | ||
| } & ( | ||
| | { | ||
| /** | ||
| * The address whose corresponding private key to use for signing. | ||
| */ | ||
| address: string; | ||
| /** | ||
| * The public key whose corresponding private key to use for signing. | ||
| */ | ||
| publicKey?: string; | ||
| } | ||
| | { | ||
| /** | ||
| * The address whose corresponding private key to use for signing. | ||
| */ | ||
| address?: string; | ||
| /** | ||
| * The public key whose corresponding private key to use for signing. | ||
| */ | ||
| publicKey: string; | ||
| } | ||
| ); |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -198,4 +198,78 @@ export class BitcoinSigner extends ccc.SignerBtc { | |||||
| ); | ||||||
| return signature; | ||||||
| } | ||||||
|
|
||||||
| /** | ||||||
| * Signs a PSBT using JoyID wallet. | ||||||
| * | ||||||
| * @param psbtHex - The hex string of PSBT to sign. | ||||||
| * @returns A promise that resolves to the signed PSBT as a Hex string. | ||||||
| */ | ||||||
| async signPsbt( | ||||||
| psbtHex: ccc.HexLike, | ||||||
| options?: ccc.SignPsbtOptions, | ||||||
| ): Promise<ccc.Hex> { | ||||||
| const { address } = await this.assertConnection(); | ||||||
|
|
||||||
| const config = this.getConfig(); | ||||||
| const { tx: signedPsbtHex } = await createPopup( | ||||||
| buildJoyIDURL( | ||||||
| { | ||||||
| ...config, | ||||||
| tx: ccc.hexFrom(psbtHex).slice(2), | ||||||
| options, | ||||||
| signerAddress: address, | ||||||
| autoFinalized: options?.autoFinalized ?? true, | ||||||
| }, | ||||||
| "popup", | ||||||
| "/sign-psbt", | ||||||
| ), | ||||||
| { ...config, type: DappRequestType.SignPsbt }, | ||||||
| ); | ||||||
|
|
||||||
| return ccc.hexFrom(signedPsbtHex); | ||||||
| } | ||||||
|
|
||||||
| /** | ||||||
| * Broadcasts a PSBT to the Bitcoin network. | ||||||
| * | ||||||
| * @remarks | ||||||
| * JoyID does not support broadcasting a signed PSBT directly. | ||||||
| * It only supports "Sign and Broadcast" as a single atomic operation via `signAndBroadcastPsbt`. | ||||||
| */ | ||||||
| async broadcastPsbt( | ||||||
| _psbtHex: ccc.HexLike, | ||||||
| _options?: ccc.SignPsbtOptions, | ||||||
| ): Promise<ccc.Hex> { | ||||||
| throw new Error( | ||||||
| "JoyID does not support broadcasting signed PSBTs directly. Use signAndBroadcastPsbt instead.", | ||||||
| ); | ||||||
| } | ||||||
|
|
||||||
| async signAndBroadcastPsbt( | ||||||
| psbtHex: ccc.HexLike, | ||||||
| options?: ccc.SignPsbtOptions, | ||||||
| ): Promise<ccc.Hex> { | ||||||
| const { address } = await this.assertConnection(); | ||||||
|
|
||||||
| const config = this.getConfig(); | ||||||
| // ccc.hexFrom adds 0x prefix, but BTC expects non-0x | ||||||
| const { tx: txid } = await createPopup( | ||||||
| buildJoyIDURL( | ||||||
| { | ||||||
| ...config, | ||||||
| tx: ccc.hexFrom(psbtHex).slice(2), | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The expression
Suggested change
|
||||||
| options, | ||||||
| signerAddress: address, | ||||||
| autoFinalized: true, // sendPsbt always finalizes | ||||||
| isSend: true, | ||||||
| }, | ||||||
| "popup", | ||||||
| "/sign-psbt", | ||||||
| ), | ||||||
| { ...config, type: DappRequestType.SignPsbt }, // Use SignPsbt type for both operations | ||||||
| ); | ||||||
|
|
||||||
| return ccc.hexFrom(txid); | ||||||
| } | ||||||
| } | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The expression
ccc.hexFrom(psbtHex).slice(2)is used to get a non-0x-prefixed hex string. A more direct and readable approach is to useccc.bytesTo(ccc.bytesFrom(psbtHex), "hex"). This avoids the intermediate step of potentially adding and then immediately removing the "0x" prefix.