This repository was archived by the owner on Jan 1, 2019. It is now read-only.
FunctionBody returns BlockStatmentNode instead of naked array.#10
Open
gabeklein wants to merge 1 commit intocjihrig:masterfrom
Open
FunctionBody returns BlockStatmentNode instead of naked array.#10gabeklein wants to merge 1 commit intocjihrig:masterfrom
gabeklein wants to merge 1 commit intocjihrig:masterfrom
Conversation
cjihrig
reviewed
Dec 6, 2016
| @@ -0,0 +1 @@ | |||
| /Users/termtm/Projects/jsparser/ecmascript.js No newline at end of file | |||
Owner
There was a problem hiding this comment.
I don't think this should be here.
Author
There was a problem hiding this comment.
ack didn't get that in the gitignore; will edit the PR and also get 1 or 2 other fixes in there I also found.
cjihrig
reviewed
Dec 6, 2016
| FunctionBody | ||
| : SourceElements | ||
| { | ||
| $$ = new BlockStatementNode($1, createSourceLocation(null, @1, @1)) |
Owner
There was a problem hiding this comment.
Can you provide a test to illustrate why this is needed.
Owner
|
A lot has changed since this project was originally created. I don't think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
FunctionBodyto insert a new BlockStatementNode into the AST, asbodyfor FunctionDeclarationNode and FunctionExpressionNode. Reason for this is to maximize compatibility with escodegen, as it expects the node when printing out a function.It's my opinion that compatibility with escodegen, or any of the other predominant code generators for that matter, is important in making this grammar a valuable tool for those attempting to build supersets of the language.