Open
Conversation
Starred messages in the main chat appear at the top of the blackboard. Starred messages in puzzle chat rooms appear in the top-right pane. Fixes #281.
Torgen
changed the title
Contributor
Author
|
Note that messages appear in the order they were posted, not the order they were starred. The catch with the latter is I might need to interleave between oldmessages and messages, whereas currently I can just put the old messages first. |
Torgen
commented
Dec 12, 2018
| # optional server-side follow-up info | ||
| followup: (( model.followupStyle() is 'server') and m.followup) or false | ||
| email: nickEmail m.nick | ||
| body: -> |
Contributor
Author
There was a problem hiding this comment.
I know this looks weird, but it works. In fact I didn't notice I had forgot the 'do' until looking at it just now.
When there's more than one .bb-chat-messages, the query selector finds the starred messages first.
We never search for all the unstarred ones, and this will make inserts faster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starred messages in the main chat appear at the top of the blackboard.
Starred messages in puzzle chat rooms appear in the puzzle info pane.
Fixes #281.
Fixes #197.