Track dependencies on local storage, and change all session properties that default to a cookie value to use our tracker instead.#307
Open
Torgen wants to merge 7 commits intocjb:masterfrom
Open
Conversation
…to a cookie value to use reactiveLocalStorage instead. This means when using ensureNick before displaying a modal, you have to ensure a nick before submitting as well, as the user may log out in another window.
Reactive storage does that for us.
It seems to have a bug where it gets into an infinite loop if you set a value twice in quick succession and have three windows open, because it writes the values back to the storage area when it may already have been updated with the replacement value. This version just keeps track of the dependencies.
Torgen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means when using ensureNick before displaying a modal, you have to ensure a nick before submitting as well, as the user may log out in another window.
Fixes #266
Fixes #273