Pass security flags and check gcc version

[SaitTalhaNisanci]

We were not passing security flags for citus community packages, which
we are for enterprise.

Also this adds the check for gcc version to make sure we are compliant
with security.

[JelteF]

isn't ifeq a Makefile thing? I believe this spec file is (ba)sh.

[JelteF]

I'd prefer if this used the same type of check as the one above for consistency, i.e. using sort -V (version sort).

[SaitTalhaNisanci]

Actually thinking about that a bit, we would enter that if it the version is equal to "4.8.2" but we don't want to, isn't that if check wrong in this case?

[JelteF]

I guess you are right, maybe a better way would be to use head -n1 and check against currentgccver

[SaitTalhaNisanci]

if currentgccver and requiredgccver are the same, then what is the difference between head -n1 or tail -n1, or checking against currentgccver or requiredgccver. I would say that we can switch to gte structure here

[SaitTalhaNisanci]

if ! [ "$(printf '%s\n' "$requiredgccver" "$currentgccver" | sort -V | head -n1)" = "$requiredgccver" ]; then
      echo WARNING: Using slower security flags because of outdated compiler
fi

or something like the above maybe

[JelteF]

yes that seems good, but maybe use != instead of ! [ ... = ... ]

And then use

if [ "$(printf '%s\n' "8.0.0" "$currentgccver" | sort -V | head -n1)" = "8.0.0" ]; then
      # add extra security flag
fi