refactor(vadr): convert usp_getVADRSummaryOverall to LINQ #5252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace stored procedure call with async LINQ query that: - Filters parent questions only (excludes child freeform text questions) - Uses AsNoTracking() for read-only query performance - Projects only needed columns from lookup tables - Calculates answer counts and percentages in-memory
Update GetVADRDetailReport endpoint to async and call GetSummaryOverallAsync instead of stored procedure method.
…rapper - Remove async method from CsetwebContextProcedures - Remove interface declaration from ICsetwebContextProcedures - Delete orphaned result class usp_getVADRSummaryOverallResult - Remove stored procedure from EF Power Tools config
Add SQL to drop stored procedure in database upgrade script since it has been replaced with LINQ equivalent.
randywoods
approved these changes
Jan 5, 2026
randywoods
deleted the
refactor/convert-usp-getvadrsummaryoverall-to-linq
branch
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converts the
usp_getVADRSummaryOverallstored procedure to an async LINQ query, following the same pattern established in PR #5244 forusp_getFirstPage. This improves code maintainability by keeping query logic in the application layer and enables better testability.Commits
023824eb4feat(business): add LINQ equivalent for usp_getVADRSummaryOverallb8781a4cdrefactor(api): update VADR endpoint to use async LINQ method26d52f333chore(datalayer): remove usp_getVADRSummaryOverall stored procedure wrapper3c5488f7achore(db): add migration to drop usp_getVADRSummaryOverallChanges
GetSummaryOverallAsyncmethod inVADRReports.csusing LINQ with EF Core best practices:AsNoTracking()for read-only query performanceGetVADRDetailReportendpoint to async to support the new methodCsetwebContextProcedures.csICsetwebContextProcedures.csusp_getVADRSummaryOverallResult.csefpt.config.jsonto remove stored procedure referenceBreaking Changes
None
Test Plan
task test:backendto verify all backend tests passtask build:backendto verify build succeedsRelated Issues
None
Release Notes
Improved code maintainability by converting the VADR summary stored procedure to a LINQ query, enabling better testability and keeping query logic in the application layer.
Checklist
task test:backend)task build:backend)task lint:backend)