Skip to content

fix: make it build#4

Open
tetraf wants to merge 1 commit intociresnave:mainfrom
tetraf:bug/cargo-build
Open

fix: make it build#4
tetraf wants to merge 1 commit intociresnave:mainfrom
tetraf:bug/cargo-build

Conversation

@tetraf
Copy link

@tetraf tetraf commented Oct 31, 2025

ref: #3

Summary by Sourcery

Restore build by fixing mutable variable usage and unifying TPU driver version methods

Bug Fixes:

  • Mark vulnerability and TPU collections as mutable to allow element insertion
  • Replace edge/habana-specific driver version calls with a unified get_tpu_driver_version in TPU detection methods

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 31, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR fixes compilation errors by marking certain vector variables as mutable and consolidating multiple driver version accessors into a single shared method.

Class diagram for updated TPUInfo methods

classDiagram
    class TPUInfo {
        +detect_edge_tpus() Result<Vec<TPUInfo>>
        +detect_intel_habana() Result<Vec<TPUInfo>>
        +get_tpu_driver_version() String
    }
    %% The following methods were updated to use get_tpu_driver_version instead of get_edge_tpu_driver_version and get_habana_driver_version
    TPUInfo : -get_edge_tpu_driver_version() String
    TPUInfo : -get_habana_driver_version() String
Loading

Class diagram for updated CPUInfo method

classDiagram
    class CPUInfo {
        +detect_vulnerabilities() Result<Vec<String>>
    }
Loading

File-Level Changes

Change Details Files
Mark vector initializations as mutable
  • Made tpus vector mutable in TPU detection methods
  • Made vulnerabilities vector mutable in CPU vulnerability detection
src/tpu.rs
src/cpu.rs
Consolidate driver version getters
  • Replaced calls to get_edge_tpu_driver_version with get_tpu_driver_version
  • Replaced calls to get_habana_driver_version with get_tpu_driver_version
src/tpu.rs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments