Skip to content

Conversation

@RGBCube
Copy link
Contributor

@RGBCube RGBCube commented Oct 28, 2025

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@RGBCube RGBCube force-pushed the change-rgbcube-vxzxxkzonwls branch 2 times, most recently from 9e45642 to 1adf39b Compare October 28, 2025 23:47
@github-actions
Copy link

github-actions bot commented Oct 28, 2025

Preview: https://2522--pr-cinny.netlify.app
⚠️ Exercise caution. Use test accounts. ⚠️

@RGBCube RGBCube force-pushed the change-rgbcube-vxzxxkzonwls branch 2 times, most recently from 0ec2145 to 2485e62 Compare October 28, 2025 23:56
@RGBCube
Copy link
Contributor Author

RGBCube commented Oct 29, 2025

Can confirm it works now:

image

Have also tested it with /html for a <details>, worked well.

@RGBCube RGBCube force-pushed the change-rgbcube-vxzxxkzonwls branch from 2485e62 to fac4a3c Compare October 29, 2025 00:05
@RGBCube
Copy link
Contributor Author

RGBCube commented Oct 29, 2025

cc @ajbura can we get this in soon? this was a continuation of an older PR and the code has attribution

@ajbura
Copy link
Member

ajbura commented Oct 30, 2025

Hey, @RGBCube currently the rainbow commands renders the raw html if you put any other formatted text in your message. Also if we use the plain text only to generate the rainbow html we will loose the formatting entirely which will create another issue. So I think we probably need to tweak the algorithm so it can process html without breaking it?

@RGBCube
Copy link
Contributor Author

RGBCube commented Oct 30, 2025

Hey, @RGBCube currently the rainbow commands renders the raw html if you put any other formatted text in your message. Also if we use the plain text only to generate the rainbow html we will loose the formatting entirely which will create another issue. So I think we probably need to tweak the algorithm so it can process html without breaking it?

Ah, yeah I hadn't thought of that. It would be easy to simply ignore any markdown and send as-is, or we could treat it as a dom and recurse inwards. I think the latter is better, I'll try to tackle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants