Skip to content

Phone Status Widget#10

Open
hydra wants to merge 5 commits intocicada-dev:masterfrom
hydra:master
Open

Phone Status Widget#10
hydra wants to merge 5 commits intocicada-dev:masterfrom
hydra:master

Conversation

@hydra
Copy link
Contributor

@hydra hydra commented Oct 10, 2011

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't Java initialize numbers to 0 by default?

@joe-trellick
Copy link
Contributor

Cool! How often does the status update? In the future it would probably make sense to add some code to ensure that it doesn't update too often, lest it run the watch battery down.

@hydra
Copy link
Contributor Author

hydra commented Oct 10, 2011

The second commit should not be in the pull request as it's not ready for mainline yet.

I was going to add a feature that ensures the watch isn't updated too often.

I'll be cleaning up the phone status and adding more features to it over the next few days and will create a new pull request when ready. In the mean time feel free to merge the first commit.

@joe-trellick
Copy link
Contributor

Oh, OK. You can avoid this problem by creating a particular change in a branch and then making your pull request for that branch only. In this case, I'll just leave this one open for now—ping this thread when you think it's ready for a look.

@hydra
Copy link
Contributor Author

hydra commented Oct 11, 2011

yeah, i've since realised how to do it and noticed something similar happened the last time i did it, but at the time you make the pull request it doesn't say that future commits to the branch will be include din the request. all seems a bit odd to me. anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants