Skip to content

Sm menu#1

Open
sdemills wants to merge 3 commits intocicada-dev:masterfrom
sdemills:SM_Menu
Open

Sm menu#1
sdemills wants to merge 3 commits intocicada-dev:masterfrom
sdemills:SM_Menu

Conversation

@sdemills
Copy link

@sdemills sdemills commented Oct 7, 2011

Changes in this branch:-

  1. Fonts copied locally into Cicada assets fonts
  2. AppList has menu changes to not scroll the menu unless necessary.
  3. Also some changes to only paint the menu lines that need to be painted but these didn't work so they are partially commented out and partially disabled within an always FALSE test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this #7 be replaced by listSize?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it should. I've not done this kind of collaboration before, and since I wanted to see if you approved of what I was doing before committing more time, that number 7 is your original code and didn't need to be changed so I left it untouched. Ultimately we should be computing the listSize, setting that variable, and using it everywhere.

I'm out for the weekend - will have email and internet access, but won't be able to do more on this now until Monday probably - unless we are rained in by bad weather and have a great internet signal in which case I might have the opportunity to have another go before Monday.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, looking forward to continuing when you're back. Enjoy the weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants