Change the APU to use time-tracking #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compute the pulse channel index only when a sample is requested. Work in progress: will not compile in this state, all other channels are broken.
Owner
|
Checked this with Pokemon Silver and it seems like the envelopes don't work correctly. Notes that are supposed to release just sustain indefinitely until the next trigger. |
Contributor
Author
|
IDK maybe tick_apu_div isn't getting calld correctly or working correctly.
Envelope looks like it should change the level though and it seems like its
using level when it generates a sample too, so I'm not sure what it would
be missing. Maybe its not ticking the envelope right or maybe the level
isn't actually updating properly.
…On Sun, Feb 25, 2024, 6:41 PM ciaran2 ***@***.***> wrote:
Checked this with Pokemon Silver and it seems like the envelopes don't
work correctly. Notes that are supposed to release just sustain
indefinitely until the next trigger.
—
Reply to this email directly, view it on GitHub
<#60 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKGF3OUQ5GANVMG656AEVDYVPD4BAVCNFSM6AAAAAAYR5SNAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRTGEYDGOJTGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the APU to use time-tracking to allow it to calculate certain parts of samples only when needed. Also update the time tracking for things like envelope and sweep to avoid having separate counters for all of them.
This change also adds a context to memory access. Currently the context just provides the time of the memory access, but it could be used to track which component is accessing memory if that ever becomes useful for handling simultaneous memory accesses.
Time tracking on memory may also be useful for rollback systems, since it could allow us to reduce the amount of things that need to be cloned in order to implement rollback.