Skip to content

Fix chromium links#209

Merged
ninelore merged 1 commit intochrultrabook:mainfrom
Owen-sz:chromium-links-fix
Oct 7, 2024
Merged

Fix chromium links#209
ninelore merged 1 commit intochrultrabook:mainfrom
Owen-sz:chromium-links-fix

Conversation

@Owen-sz
Copy link
Contributor

@Owen-sz Owen-sz commented Oct 3, 2024

All Chromium docs links in devices.json give 404, as the upstream links seemed to have changed. These are the proper links.

@ninelore ninelore linked an issue Oct 3, 2024 that may be closed by this pull request
Most of the WP Method links pre Skylake link to 404 pages #199
Closed
ninelore
ninelore approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@ninelore ninelore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Images on upstream pages are broken. Maybe we need an alternative.

Otherwise LGTM

ninelore
ninelore requested changes Oct 3, 2024
View reviewed changes
Copy link
Member

@ninelore ninelore left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw rebase is required due to merge conflicts (probably due to #208)

@Owen-sz Owen-sz force-pushed the chromium-links-fix branch from a6468bc to 0b1008f Compare October 3, 2024 21:20
@Owen-sz Owen-sz requested a review from ninelore October 3, 2024 21:23
@Owen-sz
Copy link
Contributor Author

Owen-sz commented Oct 3, 2024

Just saw rebase is required due to merge conflicts (probably due to #208)

Should be good now

ninelore
ninelore requested changes Oct 4, 2024
View reviewed changes
Copy link
Member

@ninelore ninelore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is not quite right
image

@ethanaobrien
Copy link
Contributor

ethanaobrien commented Oct 4, 2024

Can second ninelore. This has to do with the device property (list of device names) device.device.join("<br>")

PR is very difficult to review with the change in spacing, since it shows every line has changed. If possible, could we restore 4 spacing or use 2 separate commits

@Owen-sz Owen-sz force-pushed the chromium-links-fix branch from 0b1008f to 839ae2e Compare October 5, 2024 23:29
@Owen-sz
Copy link
Contributor Author

Owen-sz commented Oct 5, 2024

Fixed it

@ninelore
Copy link
Member

ninelore commented Oct 6, 2024

We have local image links that are 404. ToDo check where they went

@Owen-sz
Copy link
Contributor Author

Owen-sz commented Oct 6, 2024

We have local image links that are 404. ToDo check where they went

Which images?

@Owen-sz
Copy link
Contributor Author

Owen-sz commented Oct 7, 2024

I don't know where the Chromium images went, not seeing anything about it.

@ninelore
Copy link
Member

ninelore commented Oct 7, 2024

I will investigate it soon dw

@ninelore ninelore merged commit 9c21a94 into chrultrabook:main Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ninelore ninelore ninelore approved these changes

+1 more reviewer

@ethanaobrien ethanaobrien ethanaobrien approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Most of the WP Method links pre Skylake link to 404 pages

3 participants

@Owen-sz @ethanaobrien @ninelore