Conversation
Added feature to check if DKMS is present in the system or not
Thesola10
approved these changes
Oct 20, 2023
Comment on lines
+5
to
+10
| if [ -n "$CHECK" ] | ||
| then | ||
| echo "DKMS Present, Istalling Anbox Modules" | ||
| else | ||
| echo "DKMS Did not respond, it seems that DKMS is not Present or you are not running in sudo/root mode" | ||
| echo "To make sure, please install dkms and try running the script again with sudo" |
There was a problem hiding this comment.
Suggested change
| if [ -n "$CHECK" ] | |
| then | |
| echo "DKMS Present, Istalling Anbox Modules" | |
| else | |
| echo "DKMS Did not respond, it seems that DKMS is not Present or you are not running in sudo/root mode" | |
| echo "To make sure, please install dkms and try running the script again with sudo" | |
| if ! [ -n "$CHECK" ] | |
| then | |
| >&2 echo "DKMS command not found, it seems that DKMS is not installed or you do not have permission to use it." | |
| >&2 echo "Please install the dkms package from your distribution vendor and re-run this tool as root." |
I don't think we need to explicitly state that we found DKMS, don't mind the quick reword
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added feature to check if DKMS is present in the system or not
Added this so people wont have to keep searching why the script is not working