Open
Conversation
sfiquet
reviewed
Jul 5, 2018
sfiquet
left a comment
There was a problem hiding this comment.
Not sure if my review will be very helpful, there's a lot I'm unfamiliar with, especially Redux. It seems generally fine.
There are a lot of console.log for debugging, is it an oversight or is there a reason for keeping them?
Also in my view the fake api should be part of a test suite rather than the standard code but I guess it will do for now. I'm just wondering if you managed to test with the actual api as well?
Finally I notice you commented out the App constructor in routes.js. I think the call to super is important for React classes although I can't remember the reason. Also the state will be undefined until we use setState, which might be ok, I don't know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, feature to delete a user account is created.
api/users/:user_idwhich will:In the process I also created a
fakeApifunction to simulate logged in state, for speeding things up when working in the react development server.