Improve documentation Model Generation#6
Open
gsilano wants to merge 3 commits intochenyutao36:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @chenyutao36! This is Giuseppe Silano, a post-doc researcher at the Czech Technical University in Prague. These days, my colleague (@hendrik-s-debruin) and I have been looking at your code, especially the
Model_Generation.mscript. The aim was to understand the improvements made to the script by the latest reference publications [1, 2]. So, we started commenting out the functions in theModel_Generation.mscript trying to link to the papers. At the end of the day, we thought this work might be useful for others, too. Hence the reason behind this pull request.We think It would be great if you could review them, fixing or improving misleading or unclear parts, and then update the code in your repository.
[1] Y. Chen, M. Bruschetta, E. Picotti, and A. Beghi, "MATMPC - A MATLAB Based Toolbox for Real-time Nonlinear Model Predictive Control," 2019 18th European Control Conference (ECC), 2019, pp. 3365-3370, doi: 10.23919/ECC.2019.8795788.
[2] Y. Chen, M. Bruschetta, D. Cuccato, and A. Beghi, "An Adaptive Partial Sensitivity Updating Scheme for Fast Nonlinear Model Predictive Control," in IEEE Transactions on Automatic Control, vol. 64, no. 7, pp. 2712-2726, July 2019, doi: 10.1109/TAC.2018.2867916.