Merged
Conversation
link2xt
force-pushed
the
link2xt/opendkim
branch
from
4ffc6b2 to
8b899f3
Compare
Contributor
|
this needs a rebase, no? |
link2xt
force-pushed
the
link2xt/opendkim
branch
from
8b899f3 to
cfb89ae
Compare
missytake
approved these changes
Jan 26, 2024
Contributor
There was a problem hiding this comment.
Commit 156c934 should be merged; the other one should be replaced with the correct opendkim commit which is already on main, so, simply left out.
Note that the base branch of this PR is right now link2xt/opendkim, should be main.
ADSP RFC 5617 is declared historic because of no deployment: <https://datatracker.ietf.org/doc/status-change-adsp-rfc5617-to-historic/> However, it is declared as supported by <https://github.com/fastmail/authentication_milter>. OpenDKIM has a release note from 2014-12-27 saying "Discontinue support for ADSP" and does not support ADSP anymore. Anyway, it does not hurt to publish a TXT record indicating the strictest possible ADSP policy that we apply to all incoming mail ourselves. Unlike DMARC which allows either SPF or DKIM to pass, ADSP requires that DKIM passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on PR #186
ADSP RFC 5617 is declared historic because of no deployment:
https://datatracker.ietf.org/doc/status-change-adsp-rfc5617-to-historic/
However, it is declared as supported by https://github.com/fastmail/authentication_milter.
OpenDKIM has a release note from 2014-12-27 saying "Discontinue support for ADSP"
and does not support ADSP anymore.
Anyway, it does not hurt to publish a TXT record
indicating the strictest possible ADSP policy
that we apply to all incoming mail ourselves.
Unlike DMARC which allows either SPF or DKIM to pass,
ADSP requires that DKIM passes.
Closes #188