remove: remove unused websocket dependencies from @deltachat/jsonrpc-client
#7723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@deltachat/jsonrpc-client` follow up to #6655, looks like it was forgotten there. Let's keep it as draft until we make sure that this doesn't break anything in desktop dependency resolution or bundling. Could be that we also need to remove it from upstream yerpc (there it should ideally be an extension package, like `yerpc-websocket-transport`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #6655, looks like it was forgotten there.
Let's keep it as draft until we make sure that this doesn't breakwith theanything in desktop dependency resolution or bundling.
yerpcfix it will be safe.To be on the safe side I also removed the web socket dependencies from
yerpcin chatmail/yerpc#74.Turns out those extra wrapper dependencies are not needed anymore in nodejs1. So as soon as we release and use a new
yerpcversion with this fix we can merge this PR without any worries. And then we can also remove thewsdependency from desktop2 .Another reason for removing these dependencies is that they triggered irrelevant dependabot PRs, for a dependency that was not even used.
Footnotes
since version 22 there is official support for web sockets and browser already had native support anyway, so this wrapper library is not used anymore ↩
and then we can also remove the we dependency from desktop packages: it can just be removed from frontend and electron. and in the browser version we need a mini refactoring to migrate to the standard web sockets) ↩