Fix the Mkl fused matmul node builder bug in unit test #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we tried to run the mkl fused matmul op test and found out this bug.
2022-11-08 08:44:30.883157: F tensorflow/core/kernels/mkl_matmul_op_test.cc:262] Non-OK-status: nodeBuilder.Finalize(g, nullptr) status: Invalid argument: 3 errors while building NodeDef 'fused_matmul/_2' using Op<name=_MklFusedMatMul; sign ature=a:T, b:T, args:num_args*T -> product:T; attr=is_filter_const:bool,default=false; attr=transpose_a:bool,default=fal se; attr=transpose_b:bool,default=false; attr=T:type,allowed=[DT_BFLOAT16, DT_FLOAT]; attr=num_args:int,min=0; attr=fuse d_ops:list(string),default=[]; attr=epsilon:float,default=0.0001>:
So we tried to submit one patch to fix the problem in unit test.
The patch is integrated in the deepRec and seems to work well.