forked from DeepRec-AI/DeepRec
-
Notifications
You must be signed in to change notification settings - Fork 9
[Graph][Optimization]split+concat fusion to improve performance. #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jmaksymc
wants to merge
1
commit into
changqi1:main
Choose a base branch
from
jmaksymc:split_concat_fuse
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaksymc
pushed a commit
to jmaksymc/DeepRec-1
that referenced
this pull request
Jul 6, 2022
1b80275 to
765c38f
Compare
Author
|
Ready for review. @shanzhou2186 @changqi1 |
Owner
|
@jmaksymc Do you have some benchmark data? |
Author
|
@changqi1 All data (benchmarks, UT) are on jira - [WC1-1118]. |
Owner
Owner
|
@jmaksymc Please use the verified split_concat.cpp op to optimize the pattern. |
|
@shanzhou2186 please find comments in JIRA https://jira.devtools.intel.com/browse/WC1-1118. |
Owner
|
@jmaksymc Please submit this PR into alibaba/DeepRec |
f09c586 to
81af2a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, benchmarks and performance optimization.