Skip to content

Conversation

@jmaksymc
Copy link

WIP, benchmarks and performance optimization.

jmaksymc pushed a commit to jmaksymc/DeepRec-1 that referenced this pull request Jul 6, 2022
@aalbersk aalbersk force-pushed the split_concat_fuse branch 2 times, most recently from 1b80275 to 765c38f Compare July 6, 2022 16:39
@jmaksymc
Copy link
Author

jmaksymc commented Jul 10, 2022

Ready for review. @shanzhou2186 @changqi1

@jmaksymc jmaksymc changed the title [WIP][Graph][Optimization]split+concat fusion to improve performance. [Graph][Optimization]split+concat fusion to improve performance. Jul 11, 2022
@changqi1
Copy link
Owner

@jmaksymc Do you have some benchmark data?

@jmaksymc
Copy link
Author

@changqi1 All data (benchmarks, UT) are on jira - [WC1-1118].

@changqi1
Copy link
Owner

changqi1 commented Jul 15, 2022

@changqi1 All data (benchmarks, UT) are on jira - [WC1-1118].

@jmaksymc reply in Jira system.

@changqi1
Copy link
Owner

@jmaksymc Please use the verified split_concat.cpp op to optimize the pattern.

@akukushk
Copy link

akukushk commented Aug 1, 2022

@shanzhou2186 please find comments in JIRA https://jira.devtools.intel.com/browse/WC1-1118.

@changqi1
Copy link
Owner

changqi1 commented Aug 3, 2022

@jmaksymc Please submit this PR into alibaba/DeepRec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants