Gracefully handle ignored symlinks #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h3rmanj
commented
May 7, 2025
s0
force-pushed
the
fix/check-is-ignored-first
branch
from
65a3e68 to
5d8ab8f
Compare
s0
force-pushed
the
fix/check-is-ignored-first
branch
from
5d8ab8f to
1e78dfb
Compare
s0
approved these changes
May 7, 2025
Andarist
approved these changes
May 7, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks if the filepath is ignored before doing anything else.
This would crash when it was a symlink, when calling
workdir?.oid().Addresses changesets/action#469