Add additional image mappings from alias data #116
+289
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are mappings that I made by reversing the image aliases that power our CVE comparisons. I filtered out any mappings that DFC could make itself without the mapping.
I then had to go through these by hand correcting the significant number of false positives that are produced by the problems in our alias data.
Then I made sure each mapping existed in the catalog:
As part of this I've also corrected some existing mappings I found that I think are incorrect:
amazon/cloudwatch-agent: amazon-cloudwatch-agent-operatortoamazon-cloudwatch-agent. The agent seems like a closer match to me?ghcr.io/kyverno/kyverno: kyvernopre. First of all,kyvernoseems like a fairer match. And we'd map that anyway without the explicit mapping.docker-selenium-hubin our catalog. It'sselenium-hub.alpine/terragrunt: terragrunt-fips. I don't know why we'd specifically map this to FIPS and DFC will map it toterragruntwithout the mapping.argoproj/argocd: argocd-repo-server. We've deprecated the repo server image in favour ofargocdwhich DFC will map to anyway.calico/nodetocalico-node, notcalico-typha.cfsslis a better mapping forcfsslthancfssl-self-sign?cilium/cilium: cilium-operator-awsto map tocilium-agent. That seems more likely to me as the intended mapping.crossplane/provider-awstocrossplane-aws, rather than arbitrarily tocrossplane-aws-dynamodb.crossplane/provider-azuretocrossplane-azure, rather than arbitrarilycrossplane-azure-storage.fluxcd/flux: flux-image-automation-controller. I thinkfluxis a better match and DFC will make that without the mapping.goharbor/harbor-core: harbor-jobservice. I thinkharbor-coreis a better match and DFC will make that without the mapping.hashicorp/vault: vault-k8s. I thinkvaultis a better match and DFC will make that without the mapping.istioimage mappings to point to the correct components.jaegertracing/all-in-one: jaeger-queryto map tojaeger-all-in-onewhich is a more correct mapping.jitsucom/bulker: jitsucom-syncctlto map tojitsucom-bulker.kedacore/keda. DFC will map that tokedacorrectly anyway.library/tomcat: tomcat-jdk8. There is notomcat-jdk8and DFC will map it totomcatcorrectly anyway.dotnet-sdkmapping.quay.io/jetstack/cert-manager-controller: cert-manager-webhook. This mapping is wrong and DFC will map it correctly anyway.jupyter-base-notebbok.registryk8simage. There is a DockerHub org called that but this mapping won't capture any images under it.upstream-imageand it seems odd that if there were that it would map todapr-sentry?yet-another-cloudwatch-exporterisprometheus-yet-another-cloudwatch-exporter, notyace.redpanda-data-console. This image was withdrawn from our catalog and was never entitled to any customers anyway.