BuildTest - show differences between two images.#1816
Open
smoser wants to merge 1 commit intochainguard-dev:mainfrom
Open
BuildTest - show differences between two images.#1816smoser wants to merge 1 commit intochainguard-dev:mainfrom
smoser wants to merge 1 commit intochainguard-dev:mainfrom
Conversation
1adffed to
463a9ef
Compare
Contributor
Author
|
I came to wanting this when #1811 made changes and it was non-trivial to see them. I made a really crappy shell script there to show the differences, but this is more easily used. here is the output that would be seen by #1811 if i hadn't updated the golden. |
Contributor
Author
|
Bugger. I do not think the fails here are related. |
463a9ef to
f62d67d
Compare
This will provide much more verbose and possibly more useful output of a 'TestBuild' failure. The TestBuild test is there to show reproducibility, so verifying differences between the images are expected is needed to make decisions.
f62d67d to
fb56453
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will provide much more verbose and possibly more useful output of a 'TestBuild' failure.
The TestBuild test is there to show reproducibility, so verifying differences between the images are expected is needed to make decisions.
claude authored this, I'm sure it could be cleaner, but I was only after the result.