-
Notifications
You must be signed in to change notification settings - Fork 2
ci: auto-replace workspace:* with actual versions
#162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
workspace:* with actual versions
|
@Ryz0nd Isn't this already covered by Lerna? |
|
@eldenpark I thought so too, but when @chemonoworld was working on the Civictia integration, some packages were published with workspace:* versions. so I added this check to catch such issues early. |
| throw err; | ||
| } | ||
|
|
||
| createGitCommitAndTags(changedPackages); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of customizing the "git tag commit" behavior of Lerna? @Ryz0nd
|
I merged main into this PR for CI type-check. If you don't want it, you can revert that. |
Pull Request
CONTRIBUTING.mdand followed the guidelines.Summary
When a package depends on an unpublished
workspace:version, theyarn ci versioncommand fails, blocking the deployment process. To resolve this,workspace:version specifiers are detected duringyarn ci versionand replaced with the actual package versions.Links (Issue References, etc, if there's any)