oko 372 #143

blacktoast · 2025-12-23T08:51:14Z

Pull Request

Thank you for raising a Pull Request. Please follow the instruction.

I’ve read CONTRIBUTING.md and followed the guidelines.

Summary

siwe message UI implementation
Added test button to reproduce cases where origin and domain of tx-msg differ in Sandbox-evm

Links (Issue References, etc, if there's any)

… absolute path

- and add SignerAddressOrEmailForSiwe to be applied other style

- oko 504

- oko-503

- oko-502

Ryz0nd · 2025-12-30T01:32:19Z

internals/ci/src/cmds/deploy.ts

+  "oko-sandbox-evm": {
+    path: path.join(paths.root, "sandbox/sandbox_evm"),
+  },


I’m not sure we need to deploy sandbox_evm to Vercel. What are your thoughts?

First, the reason this was added to the current code was that I needed to deploy sandbox_evm for QA purposes.

For EVM features like EIP-712 and SIWE signature UI, using sandbox_evm is definitely more convenient, so I think it could be useful in the future as well.

Ryz0nd · 2025-12-30T01:43:21Z

...ched/src/components/modal_variants/eth/arbitrary_sig/siwe_sig/siwe_sig_title_badge/index.tsx

@@ -0,0 +1,35 @@
+import type { Theme } from "@oko-wallet/oko-common-ui/theme";
+
+import { OKO_PUBLIC_S3_BUCKET_URL } from "@oko-wallet-attached/requests/endpoints";


How about using static assets instead of fetching from S3?

For some reasons (actually I don't remember detailed) we store image in S3.
so @eldenpark How about putting it in the codebase instead of S3?

Having static assets version-controlled is unfortunately not scalable

Ryz0nd · 2025-12-30T08:07:05Z

...ched/src/components/modal_variants/eth/arbitrary_sig/siwe_sig/siwe_sig_title_badge/index.tsx

+      <picture>
+        <source srcSet={imageUrl.webp} type="image/webp" />
+        <img
+          className={styles.image}
+          src={imageUrl.png}
+          alt="sign siwe title image"
+        />
+      </picture>


It would also be good to use the newly updated ImageWithAlt component.

eldenpark · 2026-01-01T18:05:44Z

...s/modal_variants/common/metadata_content/signer_address_or_email/signer_address_or_email.tsx

+  );
+};
+
+export const SignerAddressOrEmailChangeViewTypeButton: FC<{


Please use concrete types

eldenpark · 2026-01-01T18:06:08Z

...s/modal_variants/common/metadata_content/signer_address_or_email/signer_address_or_email.tsx

 interface SignerAddressOrEmailProps {
  signer: string;
  origin: string;
+  initialViewType?: "View Address" | "Login Info";


Can this become not "optional"?

What will happen if nothing is given?

eldenpark · 2026-01-01T18:07:57Z

...ponents/modal_variants/eth/arbitrary_sig/siwe_sig/signer_address_or_email_for_siwe/index.tsx

+export const SignerAddressOrEmailForSiwe: FC<SignerAddressOrEmailProps> = ({
+  signer,
+  origin,
+  initialViewType = "View Address",


Could we avoid using "default parameter value" for any function?

eldenpark · 2026-01-01T18:08:38Z

...ched/src/components/modal_variants/eth/arbitrary_sig/siwe_sig/siwe_sig_title_badge/index.tsx

@@ -0,0 +1,35 @@
+import type { Theme } from "@oko-wallet/oko-common-ui/theme";
+
+import { OKO_PUBLIC_S3_BUCKET_URL } from "@oko-wallet-attached/requests/endpoints";


Having static assets version-controlled is unfortunately not scalable

eldenpark · 2026-01-01T18:09:03Z

...hed/src/components/modal_variants/eth/arbitrary_sig/siwe_sig/make_siwe_signature_content.tsx

@@ -0,0 +1,114 @@
+import React from "react";


eldenpark · 2026-01-01T18:09:34Z

...hed/src/components/modal_variants/eth/arbitrary_sig/siwe_sig/make_siwe_signature_content.tsx

+  theme: Theme | null;
+}
+
+export const EthereumSiweSignatureContent: React.FC<


FC instead of React.FC

eldenpark · 2026-01-01T18:10:03Z

embed/oko_attached/src/components/modal_variants/eth/arbitrary_sig/make_arbitrary_sig_modal.tsx

@@ -1,4 +1,4 @@
-import React from "react";
+import React, { useMemo, useState } from "react";


Best time to remove "React"

eldenpark · 2026-01-01T18:10:33Z

embed/oko_attached/src/utils/favicon.ts

@@ -0,0 +1,12 @@
+export function getFaviconUrl(origin: string): string {
+  if (!origin) return "";


curly brackets

eldenpark · 2026-01-01T18:11:26Z

ui/oko_common_ui/src/checkbox/check_icon.tsx

+export const CheckIcon = ({
+  size = 14,
+  color,
+}: {


Concrete type definition had better be used

blacktoast added 12 commits December 23, 2025 16:51

[embed] add getSIWEMessage and add condition to show siwe ui

d395fce

[embed] separate getSiweMessage func and make relative path import to…

8ca9c56

… absolute path

[embed] add VITE_PUBLIC_S3_BUCKET_URL in env

e74e854

[embed] make inner comp of SignerAddressOrEmail exported to share

a8185aa

- and add SignerAddressOrEmailForSiwe to be applied other style

[sandbox] add Sign SIWE Message (with wrong URI) button for testing

20da61e

[embed] add className props

ba73e86

[embed] add SiweSigTitleBadge

fcde32c

[embed] change file name and add verifySiweMessage

a7a07fb

[embed] add EthereumSiweSignatureContent and apply

1f40373

[embed] add theme in SiweSigTitleBadge

a03f6c9

[embed] make getFaviconUrl utils func

b7db0d2

[embed] add inValidOrigin warning box design

892198b

blacktoast requested review from Thunnini, eldenpark and piatoss3612 December 23, 2025 08:51

blacktoast added 9 commits December 23, 2025 18:56

[ui] when it is dark-mode, change check icon color

85cd4b6

[embed] add chain icon

c99798d

[ci] add deploy oko-sandbox-evm command

c967ba0

[embed] change text

1b2ab33

[embed] add hoverColor

817d5eb

- oko 504

[embed] adjust gap

3cd2596

- oko-503

[embed] remove favicon and adjust style

8f761e0

- oko-502

[ui] add custom classname props

7de57b0

[embed] adjust style

1dea141

blacktoast marked this pull request as ready for review December 29, 2025 03:19

Ryz0nd added 3 commits December 30, 2025 10:27

oko_attached: fix typo

38124be

oko_attached: unify file naming to underscore convention

ad614a0

oko_attached: remove console

a4dd6e5

Ryz0nd reviewed Dec 30, 2025

View reviewed changes

Ryz0nd approved these changes Dec 30, 2025

View reviewed changes

Ryz0nd reviewed Dec 30, 2025

View reviewed changes

blacktoast added 2 commits December 31, 2025 11:06

Merge branch 'main' into retto/OKO-372

bfb269c

[attahced] apply ImageWithAlt

8431c62

eldenpark requested changes Jan 1, 2026

View reviewed changes

o

7a501d2

eldenpark merged commit ddac0fe into main Jan 5, 2026
3 checks passed

		@@ -0,0 +1,35 @@
		import type { Theme } from "@oko-wallet/oko-common-ui/theme";

		import { OKO_PUBLIC_S3_BUCKET_URL } from "@oko-wallet-attached/requests/endpoints";

		@@ -1,4 +1,4 @@
		import React from "react";
		import React, { useMemo, useState } from "react";

		@@ -0,0 +1,12 @@
		export function getFaviconUrl(origin: string): string {
		if (!origin) return "";

oko 372 #143

oko 372 #143

Uh oh!

Conversation

blacktoast commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request

Summary

Links (Issue References, etc, if there's any)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ryz0nd Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

blacktoast commented Dec 23, 2025 •

edited

Loading

Ryz0nd Dec 30, 2025 •

edited

Loading