Fix typo in GPU device placement for mu_median_vec #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUG: Line 147 referenced `self.mu_media_vec` which doesn't exist. The correct attribute name is `self.mu_median_vec`. This typo caused the GPU device placement to silently fail (caught by bare except), meaning nuclear rate spline data was never placed on GPU even when a GPU was available. This could cause: 1. Degraded performance (data stays on CPU) 2. Potential device mismatch errors in downstream computations Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
cgiovanetti
approved these changes
Jan 26, 2026
Owner
cgiovanetti
left a comment
cgiovanetti
left a comment
There was a problem hiding this comment.
Thanks, I think this is also fixed on branch cara/me-hardcode but it's helpful to have it fixed on main as well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bug
File:
linx/reactions.py, line 147The code references
self.mu_media_vecbut the attribute is actually namedself.mu_median_vec(set on line 138).Impact
Because this is wrapped in a bare
except: pass, the error is silently swallowed. This means:The Fix
Change
self.mu_media_vec→self.mu_median_vec🤖 Generated with Claude Code