Add diffrax throw option to control solver error handling #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #17 - Add `throw` parameter to both BackgroundModel and AbundanceModel - Default is True (raises exceptions on solver failure) - Set to False for parameter scans where some combinations may fail - Passed through to all internal diffeqsolve calls Usage: # Default behavior (throw=True) thermo_model = BackgroundModel() abundance_model = AbundanceModel(nuclear_net) # For parameter scans (throw=False) thermo_model = BackgroundModel(throw=False) abundance_model = AbundanceModel(nuclear_net, throw=False) # Failures return partial results instead of raising Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #17
Adds a
throwparameter to bothBackgroundModelandAbundanceModelto control diffrax solver error behavior.Changes
throwattribute toBackgroundModel(defaultTrue)throwattribute toAbundanceModel(defaultTrue)throwto all internaldiffeqsolvecallsBehavior
throw=True(default): Raises exception when solver fails (e.g., max_steps reached)throw=False: Returns partial results, useful for parameter scans where some combinations may failUsage
Test plan
🤖 Generated with Claude Code