Open
Conversation
brewingcode
commented
Dec 28, 2017
| } | ||
| } | ||
|
|
||
| macro_rules! first_column { |
Author
There was a problem hiding this comment.
Macros seem really hacky, but my goal was to just declare the format strings that println!() uses in one place.
brewingcode
commented
Dec 28, 2017
| let mut width: usize = 80; | ||
| if matches.is_present("width") { | ||
| let val = matches.value_of("width"); | ||
| let x: Option<&str> = Some("full"); |
Author
There was a problem hiding this comment.
I don't have enough understanding of Rust's string comparison to compare val to a string, so I made a throwaway Option to compare to.
Contributor
There was a problem hiding this comment.
He @brewingcode! I'm not the repo person here, but I thought I might help you here. I don't think you need the temporary x here, you can straight up compare val == Some("full").
You might even be able to make something like
let width = match matches.value_of("width") {
Some("full") => return terminal width,
Some(val) => parse the thing,
None => 80,
}
This is so we can start modifying the width of the filename field (at index 0) based on a user-supplied width.
Use the terminal_size crate to use the full terminal width.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #39, filenames quickly run into truncation issues. This PR allows you to change the output width from the default of 80 chars to another value. Additionally, specifying
fullinstead of a number will use theterminal_sizecrate to use the whole width of the terminal.