This repository was archived by the owner on May 1, 2024. It is now read-only.
Fix handling of elements with name "class"#44
Open
johngrimes wants to merge 1 commit intocerner:masterfrom
Open
Fix handling of elements with name "class"#44johngrimes wants to merge 1 commit intocerner:masterfrom
johngrimes wants to merge 1 commit intocerner:masterfrom
Conversation
Contributor
Author
|
Any feedback on this pull request? |
johngrimes
force-pushed
the
fix-class-element
branch
from
16c99f6 to
8209917
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently, primitive elements with the name
classdo not have an underscore appended to them. This results in the incorrect getter/setter being called.