Skip to content

Conversation

@exkson
Copy link
Collaborator

@exkson exkson commented Aug 22, 2025

The goal of this PR is to support multiple OSDs per testnode in ceph-devstack. It includes:

  • new containers.testnode.storage_device_count config option
  • changes in Testnode.create to create loop devices according to the config option
  • supports to include additional options in sshd_config (needed to runs suite like orch:cephadm:smoke

@exkson exkson changed the title Allow loop devices config osd deploy: add config entry for osd count per testnode Aug 22, 2025
@exkson exkson changed the title osd deploy: add config entry for osd count per testnode testnode: add config entry for osd count per testnode Aug 22, 2025
@exkson exkson requested review from VallariAg, kamoltat and zmc August 22, 2025 15:46
zmc
zmc previously requested changes Aug 27, 2025
Copy link
Member

@zmc zmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good both in terms of functionality and style. Nice work @exkson!

I just see two minor tweaks needed.

@zmc
Copy link
Member

zmc commented Aug 27, 2025

I filed #32 because if I'd set that up before, there would have been a warning about lstrip :)

@exkson
Copy link
Collaborator Author

exkson commented Aug 28, 2025

Thanks for your comments Zack. Changes are applied.

Copy link
Member

@kamoltat kamoltat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@exkson please rebase the PR, other than that, this looks fine to me after Zack's comment.

@exkson exkson force-pushed the allow-loop-devices-config branch from 26315b0 to 0cb5fa1 Compare September 8, 2025 18:28
@kamoltat kamoltat dismissed zmc’s stale review September 10, 2025 15:02

Author made the change already from the request

@kamoltat kamoltat merged commit 2f6b140 into ceph:main Sep 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants