Skip to content

Conversation

@mustermeiszer
Copy link
Contributor

@mustermeiszer mustermeiszer commented Oct 7, 2025

No description provided.

@mustermeiszer
Copy link
Contributor Author

All kudos to https://github.com/cll-sa for draft that.

hieronx and others added 4 commits October 7, 2025 19:45
* Inline interface, adapt

* Add unit tests

* Remove unused param

* Fix estimate test

* Add receive cost

* Fix gas limit test

* Fix assume
@mustermeiszer
Copy link
Contributor Author

closing in favor of #700

@hieronx
Copy link
Contributor

hieronx commented Oct 8, 2025

@mustermeiszer I merged #700 into this one already

@hieronx hieronx reopened this Oct 8, 2025
@hieronx hieronx requested review from wischli and removed request for 0x4Graham and hieronx October 8, 2025 13:01
@hieronx hieronx marked this pull request as ready for review October 8, 2025 13:02
@hieronx hieronx requested a review from onnovisser October 8, 2025 13:02
@hieronx hieronx changed the title feat: CCIP Adapter feat: Chainlink CCIP Adapter Oct 13, 2025
Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks goods!

Just a non CCIP related comment

@sherlock-ai-github-agent
Copy link

Sherlock AI Findings

The automated tool completed its analysis of the codebase and found no potential security issues.

Next Steps: No immediate actions are required. Continue monitoring the codebase with future scans.

Full report available at: https://ai.sherlock.xyz/runs/a281d822-b38b-4bde-b404-8570e5649938

@github-actions
Copy link

Coverage after merging feat/ccipAdapter into main will be

97.77%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src/adapters
   AxelarAdapter.sol97.73%90%100%100%121
   ChainlinkAdapter.sol98.11%91.67%100%100%98
   LayerZeroAdapter.sol98.39%90%100%100%130
   RecoveryAdapter.sol100%100%100%100%
   WormholeAdapter.sol97.67%90%100%100%108
src/admin
   OpsGuardian.sol100%100%100%100%
   ProtocolGuardian.sol100%100%100%100%
   Root.sol100%100%100%100%
   TokenRecoverer.sol100%100%100%100%
src/core/hub
   Accounting.sol94.79%88%100%96.61%132, 134, 137, 141, 144
   Holdings.sol97.71%88.89%100%100%116, 237, 82
   Hub.sol88.63%62.26%93.02%94.58%269, 287, 305, 339, 343, 374–375, 403, 413, 423, 423, 423, 425, 439, 497–498, 543, 548, 585, 600, 74, 74–76, 76–78, 78, 78–79, 87
   HubHandler.sol98%90.91%100%100%71
   HubRegistry.sol92.13%75%100%100%117, 123, 129, 35, 46, 79, 98
   ShareClassManager.sol100%100%100%100%
src/core/libraries
   PricingLib.sol100%100%100%100%
src/core/messaging
   GasService.sol97.94%100%100%96.92%107, 117
   Gateway.sol100%100%100%100%
   MessageDispatcher.sol99.60%98.55%100%100%699
   MessageProcessor.sol83.51%60.53%100%99.07%102, 105, 112, 115, 117, 128, 133, 142, 145, 148, 160, 163, 166, 171, 181, 184, 193, 196, 199, 212, 223, 228, 231, 235, 86, 88–89, 92–93, 96–97
   MultiAdapter.sol100%100%100%100%
src/core/messaging/libraries
   MessageLib.sol100%100%100%100%
src/core/spoke
   BalanceSheet.sol99.42%96.43%100%100%57
   PoolEscrow.sol100%100%100%100%
   ShareToken.sol92.41%60%94.44%98.04%100, 112, 144, 146, 32
   Spoke.sol95.54%86.36%96.88%98.83%108, 116, 131, 131–132, 132, 134, 91, 91–92, 92
   VaultRegistry.sol93.48%87.10%100%96.23%37–38, 54, 60–62
src/core/spoke/factories
   PoolEscrowFactory.sol100%100%100%100%
   TokenFactory.sol92%50%100%94.74%24–25
src/core/utils
   BatchedMulticall.sol87.50%0%100%100%25, 25
   ContractUpdater.sol100%100%100%100%
src/hooks
   BaseTransferHook.sol98.48%100%95.83%98.80%108
   FreelyTransferable.sol92.31%80%100%100%36
   FreezeOnly.sol100%100%100%100%
   FullRestrictions.sol95.24%88.89%100%100%44
   RedemptionRestrictions.sol85.71%50%100%100%36
src/hooks/libraries
   UpdateRestrictionMessageLib.sol90%50%100%100%40, 61, 82
src/managers/hub
   NAVManager.sol100%100%100%100%
   SimplePriceManager.sol97.40%100%88.89%98.18%139
src/managers/spoke
   MerkleProofManager.sol83.58%75%88.89%85.71%103, 110, 129–130, 130, 130, 132–133, 135–136
   OnOfframpManager.sol100%100%100%100%
   QueueManager.sol100%100%100%100%
src/managers/spoke/decoders
   BaseDecoder.sol75%100%75%75%43–44
   CircleDecoder.sol0%100%0%0%11, 16, 20, 22
   VaultDecoder.sol0%100%0%0%10, 104, 110, 15–16, 22, 28, 34, 40, 46, 52, 58, 64, 69, 75, 80, 86, 9, 92, 98
src/misc
   Auth.sol100%100%100%100%
   ERC20.sol100%100%100%100%
   Escrow.sol56.25%33.33%100%66.67%17, 19, 23–24, 24, 24, 26
   Multicall.sol83.33%33.33%100%100%19, 19
   Recoverable.sol100%100%100%100%
   ReentrancyProtection.sol90%75%100%100%24
src/misc/libraries
   ArrayLib.sol100%100%100%100%
   BitmapLib.sol100%100%100%100%
   BytesLib.sol90.27%56%100%100%109, 120, 131, 14, 142, 153, 16, 164, 175, 186, 87
   CastLib.sol95.24%66.67%100%100%10, 34
   EIP712Lib.sol100%100%100%100%
   MathLib.sol93.46%76.19%100%97.33%34–35, 44, 46, 48, 50, 52
   MerkleProofLib.sol100%100%100%100%
   SafeTransferLib.sol96.97%92.86%100%100%75
   SignatureLib.sol95.24%80%100%100%17
   StringLib.sol100%100%100%100%
   TransientArrayLib.sol100%100%100%100%
   TransientBytesLib.sol100%100%100%100%
   TransientStorageLib.sol100%100%100%100%
src/valuations
   IdentityValuation.sol66.67%100%66.67%66.67%27–28
   OracleValuation.sol100%100%100%100%
src/vaults
   AsyncRequestManager.sol96.34%84.95%100%99.63%193, 217, 220, 223, 226, 237, 249, 313, 347, 461, 466, 505, 507, 556, 563
   AsyncVault.sol96.25%83.33%95%98.15%147, 48
   BaseVaults.sol92.50%80.77%95.24%93.94%126, 139, 241, 311–312, 398–399, 87–88, 88, 88–90
   BatchRequestManager.sol100%100%100%100%
   RefundEscrow.sol100%100%100%100%
   SyncDepositVault.sol100%100%100%100%
   SyncManager.sol90.40%84.62%88.24%92.68%103–104, 106, 152, 172–173, 218–219, 64, 69
   VaultRouter.sol87.41%52%100%94.25%114, 114, 116–117, 117, 119, 130–131, 150, 150, 162, 205, 77, 80–81, 93–94
src/vaults/factories
   AsyncVaultFactory.sol89.47%50%100%93.33%35, 47
   RefundEscrowFactory.sol100%100%100%100%
   SyncDepositVaultFactory.sol91.30%50%100%94.74%44, 59
src/vaults/libraries
   RequestCallbackMessageLib.sol89.58%50%100%100%104, 139, 38, 57, 77
   RequestMessageLib.sol89.74%50%100%100%37, 55, 72, 89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants