Skip to content

Idea: BatchSimplePriceManager #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
onnovisser wants to merge 101 commits into
base: main
Choose a base branch
from
Draft

Idea: BatchSimplePriceManager #656

onnovisser wants to merge 101 commits into from

Conversation

@onnovisser
Copy link
Contributor

@onnovisser onnovisser commented Oct 1, 2025 •
edited
Loading

Product requirements

  • Methods for approving and issuing on top of the SimplePriceManager

Design notes

  • How do we solve the deRWA use-case? Splitting approve and issue/revoke can lead to the price being wrong, even when tracking how many issue/revoke epochs behind we are

TODOs

  • [ ]

hieronx added 30 commits April 30, 2025 08:57
@hieronx
Setup
2c55f66
@hieronx
Add valuation
5498cb8
@hieronx
Add comment
20deae2
@hieronx
Add LTV
6052a5e
@hieronx
Add comment
97eadce
@hieronx
Fix owner check
af46b67
@hieronx
Add holding creation
5a0da6a
@hieronx
Format
4130016
@hieronx
Add linear accrual, externalize 6909
96f991d
@hieronx
Fix warning
735d2db
@hieronx
Change auth
41d2b31
@hieronx
Add update contract methods
4b7d0c3
@hieronx
Setup NAVManager
43f336a
@hieronx
Fix
32266da
@hieronx
Fix
acc84f0
@hieronx
Merge branch 'main' of github.com:centrifuge/protocol-v3 into nav-man…
f081b2e 
…ager
@hieronx
Remove loan manager code
f5467af
@hieronx
More removals
25de08e
@hieronx
Merge branch 'spearbit-fixreview' of github.com:centrifuge/protocol-v…
7290875 
…3 into nav-manager
@hieronx
Start to adapt for multiple networks
b69fd5b
@hieronx
Make it work
755944b
@hieronx
Merge branch 'post-electisec' into nav-manager
ad59f61
@hieronx
Separate price calculations
b88f835
@hieronx
Asset/expense account shared across sc's
8f8f60b
@hieronx
Start adapting end to end tests
b392f30
@hieronx
Start to integrate price manager
18243e9
@hieronx
Fix price with zero issuance
4b8345f
@hieronx
Fix tests
e494446
@hieronx
Undo
2f24461
@hieronx
Fix warnings
128829d
onnovisser and others added 27 commits September 25, 2025 15:55
@onnovisser
Merge commit '0d6a054a4a552a186e0800392925dceb79aef553' into nav-manager
8229069
@onnovisser
using crosschain batcher
0bab786
@onnovisser
cleanup
81eb1d5
@onnovisser
add separate approve/issue methods
8c34bee
@onnovisser
event
0080e3a
@onnovisser
Merge commit 'e3726f7343828b6b8b47cbf6516cc5c398913137' into nav-manager
e5100d9
@onnovisser
consts
a92f592
@onnovisser
invalid share class
a5e583c
@onnovisser
spelling
a1f3c80
@onnovisser
addNetwork + removeNetwork
41b2366
@onnovisser
split SimplePriceManager
09429e3
@onnovisser
remove setHoldingAccountId
fd81467
@onnovisser
make updateHoldingValue permissionless
6eab680
@onnovisser
rename
3d8ab8c
@onnovisser
Merge commit 'bb2668a9f7f822b7600821e583e5e7a942959737' into nav-manager
b0245e5
@onnovisser
withBatch
c7c03af
@onnovisser
Merge commit '8117133f4bfa82165cbb4a3852f4d2ebe0e66ee4' into nav-manager
c409280
@onnovisser
move QueueManager
f7060ef
@onnovisser
fix test
e73d907
@onnovisser
cleanup
3e614d9
@onnovisser @wischli
Apply suggestions from code review
b8f30c3 
Co-authored-by: William Freudenberger <w.freude@icloud.com>
@onnovisser
remove BatchSimplePriceManager
15d20ac
@onnovisser
remove _onSync
e1a2d06
@onnovisser
organize
fdaed4c
@onnovisser
remove networks from struct
33102f6
@onnovisser
Merge commit '2cf8b145e6fea6c86e2ebef9e9fa4f192dbbb500' into nav-manager
3428511
@onnovisser
re-add BatchSimplePriceManager
46e0c40
@onnovisser onnovisser added the 💡 idea Represent an idea draft based on a conversation label Oct 1, 2025
@sherlock-ai-github-agent
Copy link

sherlock-ai-github-agent bot commented Oct 1, 2025

Sherlock AI Findings

The automated tool identified the following potential security issues in the codebase. Please review the details for each issue in the linked dashboard.

# Title Severity Details
1 Incorrect NAV Per Share Calculation When Issuance is Zero During Share Revocation Medium View Details

Next Steps: Review the linked issues in the dashboard and address high-severity bugs first. Contact the team if you need assistance.

Full report available at: https://ai.sherlock.xyz/runs/a7dbdf25-f002-43e4-935a-6242ff419ff6

Base automatically changed from nav-manager to main October 2, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

💡 idea Represent an idea draft based on a conversation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@onnovisser @hieronx