Skip to content

Conversation

@aaronmgdr
Copy link
Member

@aaronmgdr aaronmgdr commented Dec 19, 2025

Description

Command could hang when there were rpc providers with unresponsive metadata urls. Set a max wait time via promise.race and setTimeout so that the command can resolve

Related issues

@aaronmgdr aaronmgdr requested a review from a team as a code owner December 19, 2025 16:31
@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2025

🦋 Changeset detected

Latest commit: b67e3e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@celo/celocli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aaronmgdr
Copy link
Member Author

Open to suggestions on the max time being to short.

@aaronmgdr aaronmgdr changed the title Aaronmgdr/metadata timeouts rpc url timeouts Dec 19, 2025
@aaronmgdr aaronmgdr changed the title rpc url timeouts fix rpc url timeouts Dec 19, 2025
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.63%. Comparing base (8a9d6aa) to head (b67e3e6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #751   +/-   ##
=======================================
  Coverage   69.63%   69.63%           
=======================================
  Files         150      150           
  Lines        7071     7071           
  Branches     1144     1162   +18     
=======================================
  Hits         4924     4924           
- Misses       2084     2087    +3     
+ Partials       63       60    -3     
Components Coverage Δ
celocli ∅ <ø> (∅)
sdk 69.15% <ø> (ø)
wallets 73.14% <ø> (ø)
viem-sdks 94.15% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

size-limit report 📦

Path Size
require('@celo/actions') (cjs) 98.85 KB (0%)
import * from '@celo/actions' (esm) 23.55 KB (0%)
import { resolveAddress } from '@celo/actions' (esm) 23.49 KB (0%)
import { getGasPriceOnCelo } from '@celo/actions' (esm) 73 B (0%)
import { getAccountsContract } from '@celo/actions/contracts/accounts' (esm) 46.11 KB (0%)
import * from '@celo/actions/staking' (esm) 50.66 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There is no timeout on retrieving metadata JSON and commands like validator:rpc-urls hang indefinitely

3 participants