-
Notifications
You must be signed in to change notification settings - Fork 31
fix rpc url timeouts #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix rpc url timeouts #751
Conversation
🦋 Changeset detectedLatest commit: b67e3e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Open to suggestions on the max time being to short. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #751 +/- ##
=======================================
Coverage 69.63% 69.63%
=======================================
Files 150 150
Lines 7071 7071
Branches 1144 1162 +18
=======================================
Hits 4924 4924
- Misses 2084 2087 +3
+ Partials 63 60 -3
🚀 New features to boost your workflow:
|
size-limit report 📦
|
Description
Command could hang when there were rpc providers with unresponsive metadata urls. Set a max wait time via promise.race and setTimeout so that the command can resolve
Related issues
validator:rpc-urlshang indefinitely #739