Update code to be compatible with Ocaml 4.13.1#22
Open
yashrk wants to merge 4 commits intocedlemo:masterfrom
Open
Update code to be compatible with Ocaml 4.13.1#22yashrk wants to merge 4 commits intocedlemo:masterfrom
yashrk wants to merge 4 commits intocedlemo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
Is this library still maintained?
I updated the code so it can be built with more recent OCaml compiler now.
PR also includes results of
dune fmt, because sometimes fixes make the formatting completely broken (for example, in a long chain of binds in Lwt-related code) and to dodune fmtwas the simplest solution to repair it.I just fixed the compilation errors quickly, because the design solutions aren't clear for me (for example, should
readbe a part of the interface ofConnection_lwtor not — some examples are still using it). Sometimes probably there is better solution, we can discuss it.Also I still can't understand how to run the test suite without TravisCI.
Thank you for your great work.