fix: passing parameters to internal function call#153
Open
Peer222 wants to merge 1 commit intocdpierse:masterfrom
Open
fix: passing parameters to internal function call#153Peer222 wants to merge 1 commit intocdpierse:masterfrom
Peer222 wants to merge 1 commit intocdpierse:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Fixes a bug for the MultiLabelClassificationExplainer class.
Parameters passed to MultiLabelClassificationExplainer.call() are not taken into account internally (internal_batch_size, n_steps) or are passed wrongly to explainer() call (embedding_type at position of class_name).
Motivation and Context
Removing the internally created explainer (explainer = SequenceClassificationExplainer(...)) and replacing it with a super().call(...) did not work because self.attributions is then overwritten and accessing self.word_attributions fails.
Tests and Coverage
Tests still succeed. (The tests specified for the additional parameters did not catch the bug)
Types of changes
Final Checklist: