Skip to content

Conversation

@SFJohnson24
Copy link
Collaborator

This PR updates the is_not_unique_relationship used in FB0904 and FB0906 by resolving some erroneous null handling. It now looks for atleast one non-null value and any other value to enforce a 1 to 1 relationship both for comparator to target and vice versa.

to test: Fb0904 and FB0906

Copy link
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add a unit test for the update.

Copy link
Collaborator

@RamilCDISC RamilCDISC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR updates the null handling in is_unique_relationship and is_not_unique-relationship. The PR was validated by:

  1. Reviewing the PR for any unwanted code or comments.
  2. Reviewing the PR logic in accordance with AC.
  3. Ensuring all unit and regression testing pass.
  4. Ensuring new tests are added covering the updated logic.
  5. Running manual testing using dev rules editor.
  6. Covered cases such as:
  • target and comparator have perfect one to one relationship.
  • one to one relationship violation in target column.
  • one to one relationship violation in comparator column.
  • one to one relationship violation in target where comparator is null.
  • one to one relationship violation in comparator where target is null.
  • both target and comparator are null.
  • multiple target and comparator are null.

@SFJohnson24 SFJohnson24 merged commit 662c640 into main Jan 28, 2026
7 of 9 checks passed
@SFJohnson24 SFJohnson24 deleted the fb0906 branch January 28, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants