-
Notifications
You must be signed in to change notification settings - Fork 27
Fb0906 #1555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fb0906 #1555
Conversation
RamilCDISC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please add a unit test for the update.
RamilCDISC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR updates the null handling in is_unique_relationship and is_not_unique-relationship. The PR was validated by:
- Reviewing the PR for any unwanted code or comments.
- Reviewing the PR logic in accordance with AC.
- Ensuring all unit and regression testing pass.
- Ensuring new tests are added covering the updated logic.
- Running manual testing using dev rules editor.
- Covered cases such as:
- target and comparator have perfect one to one relationship.
- one to one relationship violation in target column.
- one to one relationship violation in comparator column.
- one to one relationship violation in target where comparator is null.
- one to one relationship violation in comparator where target is null.
- both target and comparator are null.
- multiple target and comparator are null.
This PR updates the is_not_unique_relationship used in FB0904 and FB0906 by resolving some erroneous null handling. It now looks for atleast one non-null value and any other value to enforce a 1 to 1 relationship both for comparator to target and vice versa.
to test: Fb0904 and FB0906